check bit width to avoid panic in DeltaBitPackDecoder #8688
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder would this actually happens? Do someone meets this issue? |
It can happen if an encoder calculates the deltas in the wrong domain (I know because my first attempt at writing an encoder for cudf did just this). The spec had been ambiguous on this point, but we changed the wording to disallow this situation (apache/parquet-format#231). |
etseidl
approved these changes
Oct 24, 2025
| #[test] | ||
| fn test_delta_bit_packed_invalid_bit_width() { | ||
| // Manually craft a buffer with an invalid bit width | ||
| let mut buffer = vec![]; |
There was a problem hiding this comment.
Given the documentation here, I think adding #[allow(clippy::vec_init_then_push)] is warranted.
There was a problem hiding this comment.
I added a #[allow and pushed a commit
alamb
reviewed
Oct 24, 2025
| #[test] | ||
| fn test_delta_bit_packed_invalid_bit_width() { | ||
| // Manually craft a buffer with an invalid bit width | ||
| let mut buffer = vec![]; |
There was a problem hiding this comment.
I added a #[allow and pushed a commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
The
DeltaBitPackDecodercan panic if it encounters a bit width in the encoded data that is larger than the bit width of the data type being decoded.