[Variant] Add a VariantBuilderExt impl for VariantValueArrayBuilder #8501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @alamb -- should be a quickie |
alamb
approved these changes
Sep 29, 2025
| let mut metadata_builder = ReadOnlyMetadataBuilder::new(value.metadata().clone()); | ||
| let state = builder.parent_state(&mut metadata_builder); | ||
| ObjectBuilder::new(state, false) | ||
| let mut builder = value_builder.as_builder_ext(value.metadata().clone()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Struct#8336Rationale for this change
VariantValueArrayBuilderwas already a bit inconvenient to work with, because it provides no implementation ofVariantBuilderExt. Pathfinding for variant unshredding exposed this as an actual problem and not merely an inconvenience.What changes are included in this PR?
Add a thin wrapper for
VariantValueArrayBuilderfor which we canimpl VariantBuilderExt-- thus allowing the value builder to participate fully in the variant builder ecosystem.Are these changes tested?
Yes, existing unit tests updated to use the new capability.
Are there any user-facing changes?
New pub method
VariantValueArrayBuilder::as_builder_ext