[thrift-remodel] Write Parquet page indexes #8427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etseidl
commented
Sep 23, 2025
| Some(column_index.to_thrift()) | ||
| } | ||
| }) | ||
| .map(|column_index| Some(column_index.clone())) |
There was a problem hiding this comment.
This clone is unfortunate. We define the page and offset indexes as Vec<Vec<index>>, but they start out as Vec<Vec<Option<index>>> and ultimately return to that form. It would be nice to keep that consistent. Once the remodel is finished we can revisit this.
mbrobbel
approved these changes
Sep 25, 2025
|
gogogogogogo Sorry I can't review these PRs fast enough. I am sure they are great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Note: this targets a feature branch, not main
Rationale for this change
Continues the remodel by implementing writing of the page index structures.
What changes are included in this PR?
This PR removes the old
parquet::file::page_index::Indexenum and replaces with the newColumnIndexMetaDatastruct.Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
Yes.