[thrift-remodel] Begin replacing file metadata reader and convert footer decryption code #8313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etseidl
commented
Sep 10, 2025
| encrypted_footer: bool, | ||
| file_decryption_properties: Option<&FileDecryptionProperties>, | ||
| ) -> Result<ParquetMetaData> { | ||
| let mut prot = TCompactSliceInputProtocol::new(buf); |
There was a problem hiding this comment.
much of this deleted code wound up in thrift_gen.rs
There was a problem hiding this comment.
FYI I am messing with this code as part of #8340 (mostly I moved where it lives) -- that isn't a problem per se, I am just giving you a heads up so we can coordinate what to merge when in what order, etc
|
Thanks @etseidl -- I hope to review this PR later today or tomorrow |
alamb
approved these changes
Sep 12, 2025
| encrypted_footer: bool, | ||
| file_decryption_properties: Option<&FileDecryptionProperties>, | ||
| ) -> Result<ParquetMetaData> { | ||
| let mut prot = TCompactSliceInputProtocol::new(buf); |
There was a problem hiding this comment.
FYI I am messing with this code as part of #8340 (mostly I moved where it lives) -- that isn't a problem per se, I am just giving you a heads up so we can coordinate what to merge when in what order, etc
|
|
||
| /// create meta data from thrift encoded bytes | ||
| pub fn decode_file_metadata(buf: &[u8]) -> Result<ParquetMetaData> { | ||
| let mut prot = ThriftCompactInputProtocol::new(buf); |
|
Thanks for the review @alamb! On to the next one 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Note: this targets a feature branch, not main
Rationale for this change
Continuing the remodel
What changes are included in this PR?
This begins the process of replacing the current footer parsing code with the new version. As part of this much of the decryption machinery also needed to be changed.
Are these changes tested?
Should be covered by existing tests
Are there any user-facing changes?
Yes