Skip to content

[thrift-remodel] Redo thrift enums and unions #8072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Aug 11, 2025
Merged

[thrift-remodel] Redo thrift enums and unions #8072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
372aa32
add more thrift benches
etseidl Aug 4, 2025
a655fc3
replace more parquet::format structs with custom avatars
etseidl Jul 30, 2025
abc6bf6
add some comments
etseidl Aug 5, 2025
6cb37b9
hide format::KeyValue
etseidl Aug 5, 2025
941d546
fully qualify fmt::FileMetaData
etseidl Aug 5, 2025
3aa4574
clippy
etseidl Aug 5, 2025
8de407f
remove some unnecessary derives for KeyValye
etseidl Aug 5, 2025
aac18a8
add decoding of page headers to benchmarks
etseidl Aug 5, 2025
c4d056b
Merge remote-tracking branch 'origin/main' into no_format
etseidl Aug 5, 2025
4c0c0c9
Merge branch 'thrift_bench' into no_format
etseidl Aug 5, 2025
e6300ab
clean up SortingColumn
etseidl Aug 5, 2025
5f545a4
fix docs
etseidl Aug 5, 2025
fc00abb
fix compilation error
etseidl Aug 5, 2025
85f3db9
add new thrift decoder and support for thrift enums
etseidl Aug 6, 2025
8e9cd14
add display stuff to enum macro
etseidl Aug 6, 2025
2722e24
start adding union macros
etseidl Aug 6, 2025
78a8111
implement a few more unions
etseidl Aug 6, 2025
56e89a8
add special case thrift_union_all_empty
etseidl Aug 6, 2025
16cfe39
unused import
etseidl Aug 6, 2025
6ae6463
punt on mixed unions for now and handle manually
etseidl Aug 6, 2025
023dc28
add some unions...still needs work
etseidl Aug 6, 2025
25aa56d
don't use parquet alias for crate:format
etseidl Aug 6, 2025
6a4b198
add comment
etseidl Aug 6, 2025
83e17bf
Merge remote-tracking branch 'github/no_format' into redo_thrift_enums
etseidl Aug 6, 2025
cebfea3
Merge remote-tracking branch 'origin/gh5854_thrift_remodel' into redo…
etseidl Aug 6, 2025
33bcba9
finish merge
etseidl Aug 6, 2025
7da23d2
clippy
etseidl Aug 6, 2025
3655bd3
Merge remote-tracking branch 'origin/main' into redo_thrift_enums
etseidl Aug 11, 2025
764f73d
Merge remote-tracking branch 'origin/gh5854_thrift_remodel' into redo…
etseidl Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading