test: add tests for converting sliced list to row based#7994
Merged
alamb merged 3 commits intoapache:mainfrom Jul 27, 2025
Merged
test: add tests for converting sliced list to row based#7994alamb merged 3 commits intoapache:mainfrom
alamb merged 3 commits intoapache:mainfrom
Conversation
rluvaton
added a commit
to rluvaton/arrow-rs
that referenced
this pull request
Jul 24, 2025
Waiting for: - apache#7994 to be merged first Closes apache#7993
alamb
approved these changes
Jul 26, 2025
alamb
added a commit
that referenced
this pull request
Jul 28, 2025
…aster for small sliced list) (#7996) # Which issue does this PR close? - Closes #7993. # Rationale for this change See issue # What changes are included in this PR? only encode sliced list values and change shift the offset in encoding # Are these changes tested? Yes in: - #7994 Waiting for it to be merged first # Are there any user-facing changes? only perf --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Before I fix the issue below I wanna add tests:
RowConverteron list should only encode the sliced list values and not the entire data #7993Rationale for this change
When started fixing #7993 and I wanted to know if there were any tests that will protect me so I only changed:
arrow-rs/arrow-row/src/lib.rs
Lines 520 to 526 in 16794ab
to:
and no test failed
What changes are included in this PR?
just added tests
Are these changes tested?
Are there any user-facing changes?
No