Speedup sorting for inline views: 1.4x - 1.7x improvement#7856
Speedup sorting for inline views: 1.4x - 1.7x improvement#7856Dandandan merged 8 commits intoapache:mainfrom
Conversation
|
FYI @zhuqi-lucas |
|
Amazing work @Dandandan , reviewing now. |
zhuqi-lucas
left a comment
There was a problem hiding this comment.
LGTM thank you @Dandandan !
| _ => value_indices.len(), | ||
| }; | ||
| // 3.a Check if all views are inline (no data buffers) | ||
| if values.data_buffers().is_empty() { |
There was a problem hiding this comment.
Thank you @Dandandan , it's very clear we optimize the no data buffers path!
|
🤖 |
|
🤖: Benchmark completed Details
|
|
sorting is about to become even more crazy fast! |
Just when you think you can't make sorting faster.... Along comes @zhuqi-lucas and @Dandandan 🥳 🐶 |
alamb
left a comment
There was a problem hiding this comment.
Thank you @Dandandan and @zhuqi-lucas -- this looks great as well. I agree with @zhuqi-lucas that optimizing the short strings / no buffers case makes a lot of sense
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Speedup by specializing on batches with only inline views.
Are these changes tested?, are they covered by existing tests)?
existing tests
Are there any user-facing changes?
no