Add concatenate kernel benchmark for StringViewArray
#7617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/concat_view_benchmark
branch
from
72e2232 to
51fcd2d
Compare
This was referenced Jun 6, 2025
Dandandan
pushed a commit
that referenced
this pull request
Jun 6, 2025
…ws (#7619) # Which issue does this PR close? - Follow on to #7597 # Rationale for this change While reviewing the code and the concat kernel for - #7617 I realized there is a non trivial difference when there all inlined views vs some inlined views vs mostly large strings so the benchmarks should capture that # What changes are included in this PR? 1. Add variations of benchmark with different size strings in StringViewArray # Are there any user-facing changes? If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
coalesceandconcatperformance for views #7614Rationale for this change
We expect #7614 to improve concat performance, but we don't have any concat benchmarks for StringViewArray
Let's fix that
What changes are included in this PR?
concatbenchmark for StringViewArrayAre there any user-facing changes?
No this is an internal benchmarking tool only