Skip to content

Fix CI on main due to logical conflict #7542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 23, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

Which results in an error: https://github.com/apache/arrow-rs/actions/runs/15216929616/job/42804494443

error[E0061]: this function takes 4 arguments but 3 arguments were supplied
   --> arrow-avro/src/codec.rs:425:27
    |
425 |                 let val = make_data_type(&m.values, namespace, resolver)?;
    |                           ^^^^^^^^^^^^^^-------------------------------- argument #4 of type `bool` is missing
    |
note: function defined here
   --> arrow-avro/src/codec.rs:334:4
    |
334 | fn make_data_type<'a>(
    |    ^^^^^^^^^^^^^^
...
338 |     use_utf8view: bool,
    |     ------------------
help: provide the argument
    |
4[25](https://github.com/apache/arrow-rs/actions/runs/15216929616/job/42804494443#step:14:26) |                 let val = make_data_type(&m.values, namespace, resolver, /* bool */)?;
    |                                                                        ++++++++++++

What changes are included in this PR?

Fix compilation

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review May 23, 2025 19:36
@github-actions github-actions bot added the arrow Changes to the arrow crate label May 23, 2025
@alamb alamb merged commit 531370f into apache:main May 23, 2025
23 checks passed
@alamb
Copy link
Contributor Author

alamb commented May 23, 2025

Thank you @tustvold

@alamb alamb deleted the alamb/fix_main branch May 23, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants