object_store: Disable all compression formats in HTTP reqwest client #7143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
approved these changes
Feb 19, 2025
friendlymatthew
pushed a commit
to friendlymatthew/arrow-rs
that referenced
this pull request
Feb 21, 2025
alamb
pushed a commit
to alamb/arrow-rs
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7142.
Rationale for this change
Resolves an issue where enabling extra compression features in reqwest (
zstd,brotli,deflate) would cause the client to automatically include theAccept-Encodingheader in the request, which-- in turn-- may cause an HTTP server to respond with compression. Reqwest would then filter outContent-Lengthfrom the response, resulting in an error.What changes are included in this PR?
This PR expands on the work from #6843 to disable all the compression formats that reqwest (currently) supports. Now, in addition to disabling
gzip, the compression formatszstd,brotli, anddeflateare also disabled.Are there any user-facing changes?
Behind the scenes, the
Accept-Encodingheader on outbound HTTP requests may have changed if the reqwest featureszstd,brotli, ordeflatewere enabled. The only effect users should notice is that HTTP requests that were once failing due to a missingContent-Lengthheader may now succeed.