Improve docs for AmazonS3Builder::from_env
#6977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps the Azure and GCS |
alamb
reviewed
Jan 14, 2025
totoroyyb
pushed a commit
to totoroyyb/arrow-rs
that referenced
this pull request
Jan 20, 2025
* Improve docs for `AmazonS3Builder::from_env` * wording * Update object_store/src/aws/builder.rs --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb
added a commit
to alamb/arrow-rs
that referenced
this pull request
Mar 20, 2025
* Improve docs for `AmazonS3Builder::from_env` * wording * Update object_store/src/aws/builder.rs --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The documentation for
AmazonS3Builder::from_envmakes it seem like only specific AWS environment variables are looked for in the current environment. However any env vars starting withAWS_are checked.What changes are included in this PR?
Document that all env vars starting with
AWS_are checked, so any value inAmazonS3ConfigKeycan be used.Are there any user-facing changes?
No, documentation only.