Skip to content

Format integer floats without .0 suffix #6951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Format integer floats without .0 suffix #6951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion arrow-cast/src/display.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,15 @@ macro_rules! primitive_display_float {
{
fn write(&self, idx: usize, f: &mut dyn Write) -> FormatResult {
let value = self.value(idx);

let mut buffer = ryu::Buffer::new();
f.write_str(buffer.format(value))?;
let string = buffer.format(value);

// Remove the `.0` suffix on integers that ryu always adds:
let string = string.strip_suffix(".0").unwrap_or(string);

f.write_str(string)?;

Ok(())
}
})+
Expand Down Expand Up @@ -1219,4 +1226,11 @@ mod tests {
array_value_to_string(&map_array, 3).unwrap()
);
}

#[test]
fn test_float_arry_to_string() {
let array = Float32Array::from(vec![0.0, 1.0, 2.0, 13.37, std::f32::consts::PI]);
let default_strings = format_array(&array, &Default::default());
assert_eq!(default_strings, ["0", "1", "2", "13.37", "3.1415927"]);
}
}
Loading