Fix signed decimal e-notation parsing #6729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruuya
force-pushed
the
negative-decimal-e-fix
branch
from
7a0807b
to
0227ae3
Compare
gruuya
force-pushed
the
negative-decimal-e-fix
branch
from
0227ae3
to
ba8ba37
Compare
gruuya
commented
Nov 13, 2024
| if truthy_is_scalar && truthy.len() != 1 { | ||
| if falsy_is_scalar && falsy.len() != 1 { |
There was a problem hiding this comment.
This is just a drive-by validation fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6728.
Rationale for this change
When parsing signed decimal numbers the leading sign is stripped from the raw value bytes, and the
eindex is passed relative to the stripped slice.However, the full value is passed into
parse_e_notation, leading to a off-by-one error of the index for the signed numbers.What changes are included in this PR?
Do not strip the sign when parsing, and make the
eindex relative to the full value, thus aligningparse_e_notationandparse_decimal.Are there any user-facing changes?
None