Make downcast macros hygenic (#6400) #6620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Oct 24, 2024
| @@ -21,6 +21,11 @@ use crate::array::*; | |||
| use crate::types::*; | |||
| use arrow_data::ArrayData; | |||
|
|
|||
| #[doc(hidden)] | |||
| pub mod __private { | |||
There was a problem hiding this comment.
This is the module name that serde uses for this purpose
tustvold
force-pushed
the
make-hygenic
branch
from
6924590
to
0423ec1
Compare
alamb
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thank you @tustvold -- this looks good to me -- it might also be worth adding some tests. Perhaps you can follow @crepererum 's model in DataFusion
https://github.com/apache/datafusion/blob/main/datafusion/core/tests/macro_hygiene/mod.rs
crepererum
approved these changes
Oct 28, 2024
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
|
needs a formatting fix |
|
I pushed a fix for |
|
Thanks again @tustvold and @crepererum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6400
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?