Use Arc<[Buffer]>
instead of raw Vec<Buffer>
in GenericByteViewArray
for faster slice
#6427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Close #6408
Rationale for this change
In the
GenericByteViewArray
, thebuffers
field is a raw vector, leading to heap allocation when some methods are called, e.g.clone
,slice
. UsingArc<[Buffer]>
instead of the rawVec<Buffer>
can avoid such heap allocation.And the newly-add benchmark cases about
slice
shows the improvement:What changes are included in this PR?
Use
Arc<[Buffer]>
instead of the rawVec<Buffer>
as the type ofbuffers
field ofGenericByteViewArray
.Are there any user-facing changes?
The signature of the method
GenericByteViewArray::new_unchecked
is changed from:to
However, any usage of this method before this PR should still work without any modification.