Skip to content

Minor: improve comments in temporal.rs tests #6140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Minor: improve comments in temporal.rs tests #6140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions arrow-arith/src/temporal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1596,8 +1596,6 @@ mod tests {
ensure_returns_error(&Time64NanosecondArray::from(vec![0]));
}

// IntervalDayTimeType week, day, hour, miute, second, mili, u, nano; invalid month, year; ignores the other part
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these comments I think belong with the corresponding tests for the datatype

There are also a few typos (e.g. miute instead of minute

// IntervalMonthDayNanoType year -> nano; days don't affect months, time doesn't affect days, time doesn't affect months (and vice versa)
#[test]
fn test_interval_year_month_array() {
let input: IntervalYearMonthArray = vec![0, 5, 24].into();
Expand All @@ -1618,6 +1616,8 @@ mod tests {
assert!(date_part(&input, DatePart::Week).is_err());
}

// IntervalDayTimeType week, day, hour, minute, second, milli, u, nano;
// invalid month, year; ignores the other part
#[test]
fn test_interval_day_time_array() {
let input: IntervalDayTimeArray = vec![
Expand Down Expand Up @@ -1693,6 +1693,8 @@ mod tests {
assert!(date_part(&input, DatePart::Year).is_err());
}

// IntervalMonthDayNanoType year -> nano;
// days don't affect months, time doesn't affect days, time doesn't affect months (and vice versa)
#[test]
fn test_interval_month_day_nano_array() {
let input: IntervalMonthDayNanoArray = vec![
Expand Down Expand Up @@ -1728,7 +1730,7 @@ mod tests {
assert_eq!(10, actual.value(1));
assert_eq!(35, actual.value(2));

// Times follow from nanos, but are not affected by months or dats.
// Times follow from nanos, but are not affected by months or days.
let actual = date_part(&input, DatePart::Hour).unwrap();
let actual = actual.as_primitive::<Int32Type>();
assert_eq!(0, actual.value(0));
Expand Down