-
Notifications
You must be signed in to change notification settings - Fork 1k
Add the ability for Maps to cast to another case where the field names are different #5703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2be41c6
Add the ability for Maps to cast to another case where the field name…
HawaiianSpork 185aa53
Apply suggestions from code review
HawaiianSpork ffdc3bc
Feedback from code review
HawaiianSpork fbb0666
fix formatting
HawaiianSpork 521ce0c
Lint and format
HawaiianSpork ac3d85f
correctly set the null fields
HawaiianSpork File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
use crate::cast::*; | ||
|
||
/// Helper function that takes a map container and casts the inner datatype. | ||
pub(crate) fn cast_map_values( | ||
from: &MapArray, | ||
to_data_type: &DataType, | ||
cast_options: &CastOptions, | ||
to_ordered: bool, | ||
) -> Result<ArrayRef, ArrowError> { | ||
let entries_field = if let DataType::Map(entries_field, _) = to_data_type { | ||
entries_field | ||
} else { | ||
return Err(ArrowError::CastError( | ||
"Internal Error: to_data_type is not a map type.".to_string(), | ||
)); | ||
}; | ||
|
||
let key_field = key_field(entries_field).ok_or(ArrowError::CastError( | ||
"map is missing key field".to_string(), | ||
))?; | ||
let value_field = value_field(entries_field).ok_or(ArrowError::CastError( | ||
"map is missing value field".to_string(), | ||
))?; | ||
|
||
let key_array = cast_with_options(from.keys(), key_field.data_type(), cast_options)?; | ||
let value_array = cast_with_options(from.values(), value_field.data_type(), cast_options)?; | ||
|
||
Ok(Arc::new(MapArray::new( | ||
entries_field.clone(), | ||
from.offsets().clone(), | ||
StructArray::new( | ||
Fields::from(vec![key_field, value_field]), | ||
vec![key_array, value_array], | ||
from.entries().nulls().cloned(), | ||
), | ||
from.nulls().cloned(), | ||
to_ordered, | ||
))) | ||
} | ||
|
||
/// Gets the key field from the entries of a map. For all other types returns None. | ||
pub(crate) fn key_field(entries_field: &FieldRef) -> Option<FieldRef> { | ||
if let DataType::Struct(fields) = entries_field.data_type() { | ||
fields.first().cloned() | ||
} else { | ||
None | ||
} | ||
} | ||
|
||
/// Gets the value field from the entries of a map. For all other types returns None. | ||
pub(crate) fn value_field(entries_field: &FieldRef) -> Option<FieldRef> { | ||
if let DataType::Struct(fields) = entries_field.data_type() { | ||
fields.get(1).cloned() | ||
} else { | ||
None | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please add a negative tests for:
MapArray
s with different values forordered
?Interval
s and trying to cast to another map array where the values areDuration
s)