Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make has_min_max_set as pub fn #559

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

b41sh
Copy link
Contributor

@b41sh b41sh commented Jul 17, 2021

Which issue does this PR close?

Closes #.

Rationale for this change

in arrow-datafusion#640 we get column max/min value from parquet Statistics. In some cases, if the max/min value is not set, all values are null. When we call max or min method, it will panic. In order to avoid this, we must use has_min_max_set method to check it.

What changes are included in this PR?

make public for fn TypedStatistics::has_min_max_set

Are there any user-facing changes?

  • make fn TypedStatistics::has_min_max_set as public API

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jul 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #559 (1c07943) into master (f873d77) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   82.47%   82.47%           
=======================================
  Files         167      167           
  Lines       46144    46144           
=======================================
  Hits        38059    38059           
  Misses       8085     8085           
Impacted Files Coverage Δ
parquet/src/file/statistics.rs 94.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f873d77...1c07943. Read the comment docs.

@alamb alamb merged commit e658cb8 into apache:master Jul 19, 2021
alamb pushed a commit that referenced this pull request Jul 19, 2021
alamb added a commit that referenced this pull request Jul 20, 2021
Co-authored-by: baishen <baishen2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants