Add RecordBatch::schema_ref #5474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
tustvold
approved these changes
Mar 6, 2024
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR addresses the first part of #5342.
Closes #5463
Rationale for this change
This change allows users to directly borrow a schema from a
RecordBatch. While it is more idiomatic to achieve this using the existingRecordBatch::schemamethod (#5448 ) , this approach is less disruptive.What changes are included in this PR?
The
RecordBatch::schema_refmethod is added. Additionally,.schema()is changed to.schema_ref()when the schema returned is treated as a borrowed value.Are there any user-facing changes?
Yes, this adds a new a new method to
RecordBatch.