Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document UnionArray Panics #5456

Merged
merged 3 commits into from
Mar 3, 2024
Merged

Conversation

Kikkon
Copy link
Contributor

@Kikkon Kikkon commented Mar 2, 2024

Which issue does this PR close?

Closes #5430 .

Rationale for this change

What changes are included in this PR?

Modifying comments to satisfy the function's expected behavior.

Are there any user-facing changes?

no

@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 2, 2024
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor corrections

arrow-array/src/array/union_array.rs Outdated Show resolved Hide resolved
arrow-array/src/array/union_array.rs Outdated Show resolved Hide resolved
Kikkon and others added 2 commits March 3, 2024 11:47
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@tustvold tustvold changed the title Modifying comments to satisfy the function's expected behavior Document UnionArray Panics Mar 3, 2024
@tustvold tustvold merged commit 885461e into apache:master Mar 3, 2024
26 checks passed
@Kikkon Kikkon deleted the chore/fix_comment branch March 9, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between comments and code implementation
2 participants