fix: lexsort_to_indices unsupported mixed types with list #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
approved these changes
Mar 2, 2024
|
Thank you for the review @tustvold and the code @JasonLi-cn 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE this is code that @JasonLi-cn wrote -- I simply made the PR and ticket so we can have a place to discuss.
Which issue does this PR close?
Closes #5454
Rationale for this change
Fix bug
Note that @JasonLi-cn reports that this approach is slower than using
RowFormatas he did in apache/datafusion#9410What changes are included in this PR?
Add support to lex_sort_to_indices for
ListtypeAre there any user-facing changes?
Less bug