Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for serializing lists of dictionary encoded values to json #5399

Merged

Conversation

jhorstmann
Copy link
Contributor

Which issue does this PR close?

Related to #5314

Rationale for this change

Lists of dictionary encoded values were not supported in arrow-json 50.0 and returned a "not supported" error. While investigating I wondered why I could not reproduce the issue and realized it was already fixed on the master branch. This adds two test cases showcasing the support.

What changes are included in this PR?

Only tests, no user-facing change

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 14, 2024
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tustvold tustvold merged commit 48246ff into apache:master Feb 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants