Return error instead of panic when reading invalid Parquet metadata #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Thank you @mmaitre314 -- this looks good to me. We appreciate the contribution
| let ret = SerializedFileReader::new(Bytes::copy_from_slice(&data)); | ||
| assert_eq!( | ||
| ret.err().unwrap().to_string(), | ||
| "Parquet error: Could not parse metadata: bad data" |
There was a problem hiding this comment.
It is unfortunate that this error message isn't more specific about what part of the file is bad, but I don't think this PR makes it any better or worse
I ran this test without the changes in this PR and it paniced:
Running unittests src/lib.rs (target/debug/deps/parquet-94528dc13c197da2)
return value should have been constructed
thread 'file::serialized_reader::tests::test_file_reader_invalid_metadata' panicked at parquet/src/format.rs:4303:14:
return value should have been constructed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3279.
Rationale for this change
The Parquet crate typically returns errors instead of panics when reading invalid files. There was a panic left in the code generated by the Thrift compiler, which this PR addresses.
What changes are included in this PR?
I hit issues running regen.sh on WSL2: it looks like only the pacman command was run inside the archlinux container and the following commands were run outside of it. Not 100% sure, but wrapping all the command instead a bash command string fixed the issue for me.
Are there any user-facing changes?
SerializedFileReader::new()returns errors when it used to panic.