Result into error in case of endianness mismatches #5301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pangiole
force-pushed
the
ipc-big-endian
branch
from
d0304fa
to
3eeb15d
Compare
This commit implements the Byte Order (Endianness) recommendations we could read from the Apache Arrow official specification (quoted here): > _"At first we will return an error when trying to read a Schema > with an endianness that does not match the underlying system."_ Resolves: apache#3459
pangiole
force-pushed
the
ipc-big-endian
branch
from
3eeb15d
to
b1b4e84
Compare
tustvold
approved these changes
Jan 15, 2024
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the Byte Order (Endianness) recommendations we can read from the Apache Arrow official specification (quoted here):
Closes: #3459
Closes: #859