Remove unnecessary RefCell from FileSource #4157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Apr 28, 2023
| let mut reader = self.reader.borrow_mut(); | ||
| reader.seek(SeekFrom::Start(self.start))?; // always seek to start before reading | ||
| self.buf_cap = reader.read(&mut self.buf)?; | ||
| self.reader.seek(SeekFrom::Start(self.start))?; // always seek to start before reading |
There was a problem hiding this comment.
This is technically still racy because cloned file descriptor share a seek position, but the refcell wasn't helping prevent this
|
Closing in favour of #4156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This isn't actually necessary
What changes are included in this PR?
Are there any user-facing changes?