Add Field Constructors for Complex Fields #3992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
tustvold
commented
Mar 31, 2023
| Self::new( | ||
| name, | ||
| DataType::Union(UnionFields::new(type_ids, fields), mode), | ||
| false, // Unions cannot be nullable |
There was a problem hiding this comment.
This is potentially worth highlighting, these constructors allow us to help ensure schema invariants
tustvold
commented
Mar 31, 2023
| @@ -145,6 +147,104 @@ impl Field { | |||
| } | |||
| } | |||
|
|
|||
| /// Create a new [`Field`] with [`DataType::Dictionary`] | |||
| /// | |||
| /// Use [`Self::new_dict`] for more advanced dictionary options | |||
There was a problem hiding this comment.
IPC dictionary IDs being the most obvious example
alamb
reviewed
Mar 31, 2023
| @@ -7104,12 +7104,12 @@ mod tests { | |||
| fn test_cast_null_from_and_to_nested_type() { | |||
| // Cast null from and to map | |||
| let data_type = DataType::Map( | |||
| Arc::new(Field::new( | |||
| Arc::new(Field::new_struct( | |||
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Declaring nested schema is incredibly verbose, and for some types, especially MapArray and UnionArray, it isn't immediately obvious what constitutes a valid field.
What changes are included in this PR?
Adds various additional constructors to facilitate declaring fields of complex types.
Are there any user-facing changes?