Skip to content

Conversation

@tustvold
Copy link
Contributor

@tustvold tustvold commented Jan 5, 2022

Which issue does this PR close?

Relates to #1032.

Rationale for this change

I wish to make breaking changes to the APIs in array_reader to address #1132 among others. The APIs are somewhat convoluted to use and so I'm not sure these are intentionally public.

What changes are included in this PR?

This PR makes parquet::arrow::array_reader public only if the experimental feature flag is enabled

Are there any user-facing changes?

This is a breaking change as it removes code from the public API

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jan 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #1133 (03f940e) into master (d852229) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1133   +/-   ##
=======================================
  Coverage   82.33%   82.34%           
=======================================
  Files         169      169           
  Lines       50055    50055           
=======================================
+ Hits        41213    41216    +3     
+ Misses       8842     8839    -3     
Impacted Files Coverage Δ
arrow/src/array/transform/mod.rs 85.56% <0.00%> (ø)
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.22%) ⬆️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d852229...03f940e. Read the comment docs.

@tustvold tustvold force-pushed the array-reader-private branch from cc59c64 to 03f940e Compare January 5, 2022 08:16
@alamb alamb changed the title Make parquet::arrow::array_reader private (#1032) Make parquet::arrow::array_reader experimental (#1032) Jan 5, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a great idea.

@yordan-pavlov any concerns?

@yordan-pavlov
Copy link
Contributor

No concerns from me - I think the APIs in array_reader definitely need some work and I wouldn't be surprised if some breaking changes might be necessary, so a mechanism to allow this (such as what this PR proposes) would be useful; furthermore ArrowArrayReader only uses pub trait ArrayReader (from array_reader).

@alamb alamb merged commit bc2d7aa into apache:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants