Add lt dyn scalar kernel #1114
Merged
Add lt dyn scalar kernel #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
- Coverage 82.32% 82.31% -0.01%
==========================================
Files 168 168
Lines 49577 49604 +27
==========================================
+ Hits 40812 40833 +21
- Misses 8765 8771 +6
Continue to review full report at Codecov.
|
alamb
approved these changes
Jan 1, 2022
| | DataType::UInt32 | ||
| | DataType::UInt64 => {dyn_compare_scalar!(&left, right, key_type, lt_scalar)} | ||
| _ => Err(ArrowError::ComputeError( | ||
| "Kernel only supports PrimitiveArray or DictionaryArray with Primitive values".to_string(), |
There was a problem hiding this comment.
It would be cool to put the actual name of lt_dyn_eq here
|
I think this needs a rebase now that #1074 is merged but then it is ready to go |
matthewmturner
force-pushed
the
add_lt_dyn_scalar_kernel
branch
from
7f88bb1 to
c7ccf0b
Compare
alamb
reviewed
Jan 2, 2022
alamb
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1113
lt_dyn_scalartaskWhat changes are included in this PR?
Are there any user-facing changes?