Skip to content

implement eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn for timestamp types #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 29, 2021
Merged

implement eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn for timestamp types #1095

merged 2 commits into from
Dec 29, 2021

Conversation

@viirya
Copy link
Member

@viirya viirya commented Dec 25, 2021

Which issue does this PR close?

Closes #1086.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2021 •
edited
Loading

Codecov Report

Merging #1095 (ea4bd36) into master (8b85aa0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
+ Coverage   82.31%   82.32%   +0.01%     
==========================================
  Files         168      168              
  Lines       49420    49436      +16     
==========================================
+ Hits        40679    40700      +21     
+ Misses       8741     8736       -5
Impacted Files Coverage Δ
arrow/src/compute/kernels/comparison.rs 93.47% <100.00%> (+0.13%) ⬆️
arrow/src/array/transform/mod.rs 84.86% <0.00%> (+0.13%) ⬆️
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.22%) ⬆️
arrow/src/datatypes/field.rs 53.68% <0.00%> (+0.30%) ⬆️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b85aa0...ea4bd36. Read the comment docs.

liukun4515
liukun4515 approved these changes Dec 25, 2021
View reviewed changes
Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya
Copy link
Member Author

viirya commented Dec 29, 2021

Thanks for review. Is this ready to go?

alamb
alamb approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @viirya

arrow/src/compute/kernels/comparison.rs
/// `A_VEC` and `B_VEC` can be of type `Vec<i64>` or `Vec<Option<i64>>`.
/// `EXPECTED` can be either `Vec<bool>` or `Vec<Option<bool>>`.
/// The main reason for this macro is that inputs and outputs align nicely after `cargo fmt`.
macro_rules! cmp_i64 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice refactor

@alamb alamb merged commit 78de3ab into apache:master Dec 29, 2021
@viirya
Copy link
Member Author

viirya commented Dec 29, 2021

Thanks @alamb @jimexist @liukun4515 !

@alamb alamb mentioned this pull request Jan 6, 2022
Merged
This was referenced Jan 18, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

@jimexist jimexist jimexist approved these changes

@liukun4515 liukun4515 liukun4515 approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

implement eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn for timestamp types

5 participants

@viirya @codecov-commenter @alamb @jimexist @liukun4515