Skip to content

Optimize from_bitwise_binary_op #9378

@Dandandan

Description

@Dandandan

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
from_bitwise_binary_op Can be slow when the

  • buffer is not 64-bit aligned
  • offset is not a multiple of 8 (byte aligned) or 64 (64-bit aligned)

Describe the solution you'd like
Implement the same optimizations as in #9297

  • Align to 8 bytes
  • Don't try to return a buffer with bit_offset 0 but round it to a multiple of 64
  • Use chunk_exact for the fallback path

Describe alternatives you've considered

Additional context

Metadata

Metadata

Labels

enhancementAny new improvement worthy of a entry in the changelog

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions