Skip to content

Introduce Time fields in record API, and resolve bug from #7510 #7543

Open
@njaremko

Description

@njaremko

Describe the bug
I recently wrote a PR for #7510 that was wrong. So this is rectifying that.

I had used TimestampMillis for a time value that does not have a date, which is wrong.

I've added two new Fields for the missing concept of "time without date", and fixed the conversion to use them, and added the required trait implementations

To Reproduce
Try to parse a TIME_MILLIS parquet value using current main

Expected behavior
You get a field holding the number of milliseconds since midnight, but instead you'll get a field holding the number of milliseconds since epoch.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions