-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
arrowChanges to the arrow crateChanges to the arrow cratearrow-flightChanges to the arrow-flight crateChanges to the arrow-flight crateenhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelog
Description
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I have a Flight server that I'm working to cut over to Flight SQL. The bulk ingest (equivalent of do_put) has been a challenge.
Describe the solution you'd like
I noticed that the current stable version of the Flight SQL protobuf definition (17.0) defines a new CommandStatementIngest that looks like it would do exactly what I need to do.
I believe we would need to
- Regen the protobuf definitions for the currently stable 17.0
- Add a new method to the
FlightSqlServicetrait:do_put_statement_ingest - Add a new branch to the match statement to match
CommandStatementIngest - Update examples
async fn do_put_statement_ingest(
&self,
ticket: CommandStatementIngest,
request: Request<PeekableFlightDataStream>,
) -> Result<DoPutUpdateResult, Status> {
Err(Status::unimplemented("Implement do_put_statement_ingest"))
}Describe alternatives you've considered
Additional context
I'm happy to work on a patch but I'm not sure if this would need to be part of a bigger update to fully support Flight SQL 17.0. I haven't done a diff of the specs to understand all the changes.
Metadata
Metadata
Assignees
Labels
arrowChanges to the arrow crateChanges to the arrow cratearrow-flightChanges to the arrow-flight crateChanges to the arrow-flight crateenhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelog