-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
arrowChanges to the arrow crateChanges to the arrow crateenhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changeloggood first issueGood for newcomersGood for newcomershelp wanted
Description
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
When fixing issue apache/datafusion#11076, I noticed the error message when overflowing in ArrowNativeTypeOp::neg_checked
doesn't include the operation that caused the overflow, only the number itself.
DataFusion CLI v39.0.0
> select (- -9223372036854775808);
Arrow error: Compute error: Overflow happened on: -9223372036854775808
Describe the solution you'd like
Shouldn't this be:
DataFusion CLI v39.0.0
> select (- -9223372036854775808);
Arrow error: Compute error: Overflow happened on: - -9223372036854775808
Describe alternatives you've considered
Additional context
Metadata
Metadata
Assignees
Labels
arrowChanges to the arrow crateChanges to the arrow crateenhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changeloggood first issueGood for newcomersGood for newcomershelp wanted