Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concat::tests::test_string_dictionary_merge failure fails on Mac / has different results in different platforms #5255

Closed
doki23 opened this issue Dec 29, 2023 · 3 comments · Fixed by #5461
Labels
arrow Changes to the arrow crate bug good first issue Good for newcomers help wanted

Comments

@doki23
Copy link
Contributor

doki23 commented Dec 29, 2023

Describe the bug

I ran test_string_dictionary_merge both in linux x86_64 and macos aarch64 platforms and got different results. It succeeded in linux x86_64 whose values' len is 33 and failed in macos aarch64 whose values' len is 32. It's because interner.intern produces different results when build interleave indices for new values array.

To Reproduce

Run cargo test both in above 2 platforms.

Expected behavior

The test can successfully pass in both platforms.

@doki23 doki23 added the bug label Dec 29, 2023
@doki23 doki23 changed the title test_string_dictionary_merge has different results in different platform test_string_dictionary_merge has different results in different platforms Dec 29, 2023
@tustvold
Copy link
Contributor

I think this may be expected, as the interning is best effort

@doki23
Copy link
Contributor Author

doki23 commented Dec 29, 2023

Yes, it's expected, but the test will failed. Maybe we should introduce conditional compilation in this test?

@alamb alamb changed the title test_string_dictionary_merge has different results in different platforms concat::tests::test_string_dictionary_merge failure fails on Mac / has different results in different platforms Jan 19, 2024
tustvold added a commit to tustvold/arrow-rs that referenced this issue Mar 3, 2024
tustvold added a commit that referenced this issue Mar 3, 2024
* Fix test_string_dictionary_merge (#5255)

* Clippy
@tustvold tustvold added the arrow Changes to the arrow crate label Mar 15, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #5461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug good first issue Good for newcomers help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants