Skip to content

Conversation

@rajatgoel
Copy link

Which issue does this PR close?

Closes #589

What changes are included in this PR?

There are 2 changes -

  • Support AWS_ENDPOINT_URL_S3 as an alternative env var that sets S3 endpoint.
  • Process env vars in the same order as official AWS CLI/SDK does.

Are there any user-facing changes?

If this env var is not set, this should be a no-op. But if this env var is set,
our code will start respecting that. Probably worth calling out in the release notes.

@tustvold
Copy link
Contributor

tustvold commented Jan 3, 2026

Unless this is something standard, i.e. supported by AWS SDKs, I'm a bit lukewarm on this. I don't want to be in a position where we have to support a huge number of config names just because they happen to collide in some people's environments.

with_config is the escape hatch for people who want to customise the environment variable logic

@rajatgoel
Copy link
Author

Yes, this is a standard aws env var - https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AWS_ENDPOINT_URL_S3 in aws backend

2 participants