refactor!: Consolidate ObjectStore: rename & rename_if_not_exists => rename_opts
#555
+174
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This helps #385 and #297.
Rationale for this change
Change the
ObjectStorecore trait to have a single, extensible copy operation.Also adds extensions similar to
apache/arrow-rs#7170
and
apache/arrow-rs#7213 .
Also see #548 for the same change that was made for
copy.What changes are included in this PR?
Interface change, see section below.
Are there any user-facing changes?
rename_optsalongsideRenameOptions&RenameModerename&rename_if_not_existsare moved toObjectStoreExt