-
Notifications
You must be signed in to change notification settings - Fork 3
chore: Publish docs #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Publish docs #166
Conversation
RC example: https://github.com/kou/arrow-js/releases/tag/v20.0.0-rc3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kou are those scripts and workflows based on any other of our repos or is this process completely different? I am currently losing track on how we do things on others. I tried to understand what was going on with the different branches / directories / forks and really got it when I read the description of the PR. It seems quite important to understand the process, should we add something similar to the PR description to the documentation?
In general looks good to me, I am just slightly concerned whether we will be able to remember what was going on with the different branches/folders/workflows once we have to update it in the future.
These implementations are completely different from others. apache/arrow-adbc and apache/arrow-nanoarrow are only automate documentation publishing. apache/arrow-adbc nor apache/arrow-nanoarrow don't support preview by GitHub Pages on fork. So apache/arrow-js implementation is (a bit?) more complex than them.
Good point. I'll add |
Thanks, I think this will be helpful in the future. |
How about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a couple of nits
|
What's Changed
Build docs by CI and:
Push an RC tag:
Push a release tag:
https://arrow.apache.org/js/{current,${VERSION}}
via the asf-site branchPush to main in apache/arrow-js:
Push to non main in apache/arrow-js:
Push to foks:
Closes #10.