Make UUID implementation available for downstream projects#824
Closed
bodduv wants to merge 2 commits intoapache:mainfrom
Closed
Make UUID implementation available for downstream projects#824bodduv wants to merge 2 commits intoapache:mainfrom
bodduv wants to merge 2 commits intoapache:mainfrom
Conversation
lidavidm
requested changes
Aug 22, 2025
Member
lidavidm
left a comment
There was a problem hiding this comment.
The UUID type here was never meant to be a real type, it was implemented solely for testing things and doesn't match the UUID canonical extension type. If there's a desire for a UUID type, please open a new issue and implement the canonical extension type instead.
Contributor
Author
|
@lidavidm thank you for the comment! I can open an issue and work on this. I have a couple of questions:
|
Member
|
It's possible they are the same, but at the very least the extension name here is wrong, and I would prefer it be clearly documented and in its own namespace, and for everything to be reviewed with that in mind instead of just moving test code into a feature that has to be supported long-term. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
This PR moves the UUID implementation from
teststo appropriate locations so downstream projects can use them. This allows to avoid downstream projects to have their own custom implementation for a well-understood data type. A few modifications, such as the useArrowBuf, are proposed.Closes #823 .