Skip to content

MINOR: Add explicit exception when no more buffer can be read when loading buffers #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 4, 2025

What's Changed

When VectorLoader tries to load buffers (i.e., loadBuffers), it has detect on the error case that some buffers are not consumed. But another error that the number of buffers is less than expected is not handled for now. Once it is happened, users will get java.util.NoSuchElementException which is not easy to understand.

This patch adds an explicit exception for such case.

See more discussion at #648.

This comment has been minimized.

@lidavidm lidavidm added the enhancement PRs that add or improve features. label Mar 4, 2025
@viirya
Copy link
Member Author

viirya commented Mar 4, 2025

This request has been automatically failed because it uses a deprecated version of `actions/cache: 6849a6489940f00c2f30c0fb92c6274307ccb58a`. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. 

Seems CI has some issues? I may not be able to handle it for now. Leave it to others or I can take a look tomorrow. Thanks.

@jbonofre
Copy link
Member

jbonofre commented Mar 4, 2025

FYI, I'm working on a PR about GitHub Action. It will be available soon and this PR can be rebase after the merge of my PR.

@viirya
Copy link
Member Author

viirya commented Mar 4, 2025

FYI, I'm working on a PR about GitHub Action. It will be available soon and this PR can be rebase after the merge of my PR.

Thank you @jbonofre

@jbonofre
Copy link
Member

jbonofre commented Mar 4, 2025

See #650

@viirya
Copy link
Member Author

viirya commented Mar 4, 2025

Rebased.

@viirya
Copy link
Member Author

viirya commented Mar 4, 2025

Thanks @lidavidm @jbonofre

One question. How do you merge PRs in this repo? Just use merge button or there is a script for it?

@jbonofre
Copy link
Member

jbonofre commented Mar 4, 2025

@viirya we are using "merge button", but only committers/PMC members can do that.

@viirya viirya merged commit 5e71a2a into apache:main Mar 4, 2025
26 checks passed
@viirya
Copy link
Member Author

viirya commented Mar 4, 2025

Thank you @jbonofre. I merged this.

@viirya viirya deleted the improve_error branch March 4, 2025 17:43
@lidavidm lidavidm added this to the 18.3.0 milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that add or improve features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants