Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-142: [Parquet] Fix inconsistency with total_byte_size #144

Merged
merged 2 commits into from
Sep 30, 2024
Merged

GH-142: [Parquet] Fix inconsistency with total_byte_size #144

merged 2 commits into from
Sep 30, 2024

Conversation

zeroshade
Copy link
Member

Update our generated Parquet code and fixing the metadata writing to properly write total_byte_size as the total uncompressed size of the column data.

@zeroshade zeroshade requested a review from kou September 27, 2024 15:47
kou
kou approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

The SortingColumns change is unrelated to total_byte_size fix, right?

@zeroshade
Copy link
Member Author

@kou Yea, the SortingColumns change is unrelated, just something I came across after I generated the updated thrift code + was comparing against the C++ implementation to ensure compatibility. Seemed like a quick easy win to add the support.

@zeroshade zeroshade merged commit 6798d6b into apache:main Sep 30, 2024
24 checks passed
@zeroshade zeroshade deleted the row-group-total-byte-size branch September 30, 2024 14:03
@zeroshade zeroshade mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeroshade @kou