Allow C Data Interface export of ReadOnlyMemory-backed buffers #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@adamreeve, I'd like to enable experimental native compilation of C# ADBC drivers -- which requires this feature or something like it. I'm mitigating the risk of the change by marking it as experimental and effectively making it "opt-in" by consuming code. |
adamreeve
approved these changes
Oct 7, 2025
Contributor
adamreeve
left a comment
adamreeve
left a comment
There was a problem hiding this comment.
👍 putting this behind an experimental feature makes sense to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partly addresses #111 by allowing C Data Interface export of buffers backed by
ReadOnlyMemoryrather than anIMemoryOwner. This is useful if you want to export data that has been read from an IPC file or stream for example. Previously you would need to first copy all buffers for this to work.Because this is an experimental feature and potentially risky, it must currently be enabled by setting the global static
CArrowArrayExporter.EnableManagedMemoryExporttotrue.This change was originally submitted by @adamreeve as apache/arrow#40992. My only contribution is disabling the feature by default.