GH-319: [Java] recipe to concatenate value vectors as one #320
Conversation
Changed |
java/source/data.rst
Outdated
| toAppend.setValueCount(4); | ||
| System.out.println("IntVector to Append: " + toAppend); | ||
| VectorAppender appenderUtil = new VectorAppender(initialValues); | ||
| ValueVector resultOfVectorsAppended = toAppend.accept(appenderUtil, null); |
There was a problem hiding this comment.
We don't need to close this? If it mutates the original vector, we should write it in a way that makes that clear
There was a problem hiding this comment.
Do you have any ideas why the leak wasn't caught? Maybe this ValueVector is also deleted after the dependencies were closed?
There was a problem hiding this comment.
probably because it mutates the original vector instead of allocating a new one...
There was a problem hiding this comment.
Added more detail
There was a problem hiding this comment.
Just...don't use the return value.
There was a problem hiding this comment.
Also given this was a private API before, I would prefer fixing upstream to just not return the vector
There was a problem hiding this comment.
I have updated the recipe to not use the return value. It is necessary to analyze the change upstream to not return value since it is part of the Value Vector.
|
Can you rebase here? |
…w-cookbook into value-vector-appender
This comment was marked as resolved.
This comment was marked as resolved.
|
Oh, hmm, never mind that. |
2 participants
To close #319
Due to the use of JShell to run cookbook, it is not possible to create packages to access package-private objects, such as the org.apache.arrow.vector.util package. Therefore, I am only adding the recipe as a code block.