feat(csharp/src/Drivers): Format thrift error #3019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with HTTP status codes
CurtHagenlocher
changed the title
CurtHagenlocher
requested changes
Jun 25, 2025
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks! I've left a few nitpicking comments and a question.
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Threading; | ||
| using System.Text.RegularExpressions; |
| internal static string FormatTransportExceptionMessage(Exception exception) | ||
| { | ||
| var customMsg = ""; | ||
| // Use ContainsException to robustly find TTransportException or HttpRequestException |
Contributor
There was a problem hiding this comment.
This comment doesn't line up well with what the code is doing.
| } | ||
| } | ||
| } | ||
| return $"{customMsg}{Environment.NewLine}{exception.Message}"; |
Contributor
There was a problem hiding this comment.
The newline here is being added even when customMsg is empty. Does that produce the desired experience?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Transport Exception Error Messages in C# Apache Driver
This PR enhances the error handling for Thrift transport exceptions in the C# Apache driver by adding a new method
FormatTransportExceptionMessagethat extracts HTTP status codes from exception messages and provides more user-friendly error messages for common HTTP errors (401, 403, 404).Proposed changes
FormatTransportExceptionMessagemethod to extract and format HTTP status codes from Thrift transport exceptionsFormatExceptionMessagemethod to use the new formatting functionHow is this tested