fix(python/adbc_driver_postgresql): handle kwargs in dbapi connect#2700
Merged
Conversation
fwojciec
changed the title
Member
|
Thanks for the PR. Let me debug what's going on and I'll file a new PR. |
Member
|
See #2701 (I need to add some tests) Also, I had to tweak the test: |
Contributor
Author
|
I've updated the test in this PR to include your change from the comment above - and uncommented it. Thank you! |
Member
|
Ok, if you rebase things should be fixed |
fwojciec
force-pushed
the
fix-pgsql-connect-kwargs
branch
from
7c1ce74 to
ded2474
Compare
Contributor
Author
|
Hi @lidavidm, Done! I've rebased this branch onto the latest main and force-pushed the update. Confirmed locally that all tests are passing now. Thanks! |
colin-rogers-dbt
pushed a commit
to dbt-labs/arrow-adbc
that referenced
this pull request
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2696
But I've encountered some issues when writing a test for the change:
db_kwargsbeyonddriveranduri- which are set explicitlyconn_kwargs- only two appear to be supported:adbc.connection.autocommit- which is configurable explicitlyadbc.connection.db_schema- which seems to cause a SEGFAULT when I add a test that tries to set this usingconn_kwargsThe SEGFAULT happens only when I'm trying to set this specific option, when I change the key I get the expected
adbc_driver_manager.NotSupportedError: NOT_IMPLEMENTED: [libpq] Unknown option adbc.connection.db_schema2error. All other tests in the suite pass, so I don't think it's a general setup issue.the test is commented out in the
tests/test_dbapi.pyfile. pytest output:I'm wondering if it even makes sense to "fix" this given the above?