feat(c/driver_manager): expose ADBC functionality in DBAPI layer #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulcd
reviewed
Oct 6, 2022
| @@ -435,11 +753,15 @@ def fetch_arrow_table(self) -> pyarrow.Table: | |||
| ) | |||
| return self._results.fetch_arrow_table() | |||
|
|
|||
| def fetch_df(self): | |||
| def fetch_df(self) -> "pandas.DataFrame": | |||
There was a problem hiding this comment.
is the import pandas required only because of this?
There was a problem hiding this comment.
Yes, though it's behind typing.TYPE_CHECKING so it shouldn't lead to anything at runtime
lidavidm
force-pushed
the
py-extensions
branch
from
8dbda62 to
9827bcd
Compare
lidavidm
force-pushed
the
py-extensions
branch
2 times, most recently
from
b3dc3ef to
c3691f4
Compare
lidavidm
force-pushed
the
py-extensions
branch
from
c3691f4 to
3e19baa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the DBAPI interface with methods to expose ADBC functionality that doesn't have equivalents in DBAPI.