-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(c/driver/postgresql): Inital COPY Writer design #1110
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b2ff1ef
feat(c/driver/postgresql): Inital COPY Writer design
WillAyd 2d8c4b3
destructor
WillAyd b6c2492
try cast
WillAyd a6b04fe
size_t
WillAyd 9b32b2d
cursor
WillAyd a4a4834
cursor assignment
WillAyd a24ca5d
update test
WillAyd dbdc4f2
add bytes to buffer
WillAyd 897248e
use expect instead of assert
WillAyd 55b0e60
fix specializations
WillAyd 2a82645
remove array_size_approx_bytes from Writer
WillAyd 575b00f
add expect message
WillAyd 8548161
initialize records_written
WillAyd b065b45
remove verbose EXPECT_EQ
WillAyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use expect instead of assert
- Loading branch information
commit 897248e5dfad5f02e865386036f2785f10a7f387
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately when we implement this in statement.cc I imagine we will build the buffer (maybe even in chunks) and send that via
PQputCopyData
. When all is said and done we would then do aPQputCopyEnd
to send the last 4 bytes. Maybe we should make the end message a constant in the tests so it is clear what is part of the "data" versus the sentinel signaling the end of the buffer