Detect SQLITE database locked

[IIFE]

What would you like help with?

Hi,

Is there an explicit error code that would allow me to detect when a SQLITE update/insert fails because the database is locked? Currently I'm checking if the message field from AdbcError ends with database is locked, but that feels brittle.

Thanks.

[lidavidm]

Hmm. In theory what we could/should do is stash SQLite's result code in the vendor_code field. But we don't currently do that.

[IIFE]

That would be helpful @lidavidm.

I can take a look if you can point me in the right direction and files to change?

[lidavidm]

Nearly the entire driver lives in one file, https://github.com/apache/arrow-adbc/blob/main/c/driver/sqlite/sqlite.cc. Unfortunately the changes would be scattered all about; any time we get a code from SQLite, it may potentially have to be accounted for. And the helpers used to construct errors are used inconsistently and don't account for vendor code, so the first order of business might be simply to decide on the API there.

[IIFE]

so the first order of business might be simply to decide on the API there.

What do you mean by that sorry? As in the mechanism to set the vendor code?

[lidavidm]

Ah, just whether there's need to modify/add any helper functions (or just do it by hand at potential callsites)