Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java: Add JNI bindings to adbc.h #2027

Open
danepitkin opened this issue Jul 19, 2024 · 6 comments · May be fixed by #2401
Open

java: Add JNI bindings to adbc.h #2027

danepitkin opened this issue Jul 19, 2024 · 6 comments · May be fixed by #2401
Labels
Type: enhancement New feature or request

Comments

@danepitkin
Copy link
Member

danepitkin commented Jul 19, 2024

What feature or improvement would you like to see?

Add JNI generic bindings to the Java API in java/core and java/driver-manager. This generic set of bindings will allow Java users to use any ADBC driver written that also supports the C interface e.g. C++ & Go drivers.

@danepitkin danepitkin added the Type: enhancement New feature or request label Jul 19, 2024
@danepitkin danepitkin changed the title [Java] Add JNI bindings to adbc.h java: Add JNI bindings to adbc.h Jul 26, 2024
@vibhatha
Copy link

@danepitkin Let's correct the adbc.h path to https://github.com/apache/arrow-adbc/blob/main/go/adbc/drivermgr/arrow-adbc/adbc.h, I think it has changed after this issue was created.

Also I would assume the all the methods marked ADBC_EXPORT are the methods to be exposed via JNI or do we have a subset of methods we would like to see first?

@lidavidm
Copy link
Member

Look at it the other way, you would implement the java interfaces via JNI calls

@vibhatha
Copy link

Right, I am pretty new to the driver API here, is there a reference that I can take a look at and determine the Java interfaces we need?

@danepitkin
Copy link
Member Author

Updated! Thanks for letting me know the link was broken. I added links to the Java APIs that we would want to implement in JNI.

@vibhatha
Copy link

Thanks @danepitkin I will take a look.

@lidavidm
Copy link
Member

This would be useful to get access to Snowflake/BigQuery/PostgreSQL (with proper performance/features) from Java.

lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Dec 30, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Dec 30, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Dec 31, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Jan 3, 2025
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Jan 3, 2025
@github-actions github-actions bot added this to the ADBC Libraries 16 milestone Jan 3, 2025
@lidavidm lidavidm removed this from the ADBC Libraries 16 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants