Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Windows cgo builds are flaky #1088

Closed
lidavidm opened this issue Sep 20, 2023 · 2 comments · Fixed by #1153
Closed

ci: Windows cgo builds are flaky #1088

lidavidm opened this issue Sep 20, 2023 · 2 comments · Fixed by #1153
Assignees

Comments

@lidavidm
Copy link
Member

         # github.com/apache/arrow-adbc/go/adbc/pkg/flightsql
         C:\hostedtoolcache\windows\go\1.19.13\x64\pkg\tool\windows_amd64\link.exe: running gcc failed: exit status 1
         C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-1999518613\000006.o: in function `_cgo_preinit_init':
         \\_\_\runtime\cgo/gcc_libinit_windows.c:40: undefined reference to `__imp___iob_func'
         C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-1999518613\000006.o: in function `x_cgo_notify_runtime_init_done':
         \\_\_\runtime\cgo/gcc_libinit_windows.c:105: undefined reference to `__imp___iob_func'
         C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-1999518613\000006.o: in function `_cgo_beginthread':
         \\_\_\runtime\cgo/gcc_libinit_windows.c:149: undefined reference to `__imp___iob_func'
         C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-1999518613\000007.o: in function `x_cgo_thread_start':
         \\_\_\runtime\cgo/gcc_util.c:18: undefined reference to `__imp___iob_func'
     5>collect2.exe : error : ld returned 1 exit status [D:\a\arrow-adbc\arrow-adbc\adbc\build\driver\flightsql\adbc_driver_flightsql_target.vcxproj]

It looks to be something like golang/go#51007 or golang/go#57455 or golang/go#47257 and we can fix this by bumping to Go 1.20.

@lidavidm lidavidm added this to the ADBC Libraries 0.8.0 milestone Sep 20, 2023
@lidavidm lidavidm self-assigned this Sep 20, 2023
@lidavidm
Copy link
Member Author

Leaving out of 0.7.0 since I think retrying the build will work but if not this will get cherry-picked into 0.7.0 instead.

@lidavidm lidavidm removed their assignment Sep 22, 2023
@lidavidm
Copy link
Member Author

CC @ywc88, I think we just have to bump the Go version used to 1.20 for Windows sections of the packaging and build pipelines

@lidavidm lidavidm self-assigned this Oct 3, 2023
lidavidm added a commit that referenced this issue Oct 3, 2023
- Linux/macOS use cibuildwheel so they already picked up 3.12.
- We skip testing on 3.12 since PyArrow wheels are not available.
- Upgrade the Go version in Windows CI to avoid a build error.

Fixes #1088.
Fixes #1116.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant