Skip to content

[ARIES-2159] fix NPE when DatabaseMetaData wants to get connection from DummyDataSource #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ARIES-2159] fix NPE when DatabaseMetaData wants to get connection from DummyDataSource #16

wants to merge 1 commit into from
+49 −0

Conversation

jherkel
Copy link

@jherkel jherkel commented Oct 30, 2024

@glimmerveen
Copy link

Hi @jbonofre , would you be able to look into this PR?

@jbonofre
Copy link
Member

@glimmerveen it's on my todo not yet started.

@glimmerveen
Copy link

Hi @jbonofre , any update on this?

@alien11689
Copy link
Contributor

Hi @jherkel @glimmerveen
could you provide a test covering newly added code?
It could be a quite simple test just calling getConnection().getCatalog() ensuring that the NPE is not thrown.

@jherkel
Copy link
Author

jherkel commented Jun 18, 2025

@alien11689 I have added a simple unit test.

alien11689
alien11689 approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@alien11689 alien11689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jbonofre would you like to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alien11689 alien11689 alien11689 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jherkel @glimmerveen @jbonofre @alien11689